Conversation
|
@christeredvartsen I just rebased this, so I think it's ready now. The only functional change is in |
christeredvartsen
left a comment
There was a problem hiding this comment.
Thanks a bunch for the improvements. I have left a few comments in the review.
17b75bf to
7c7011b
Compare
7c7011b to
d220778
Compare
|
The |
|
Also, since |
Allows us to use bash instead of powershell on all runners
Added json and fileinfo extensions for PHP setup.
|
The remaining failures are most like because of newline mismatch. It will be clearer when I try it on my machine at home later on today. |
Sounds good. Perhaps some sort of normalization of newlines before matching might be an improvement? |
…tension into chore/various-fixes
|
I figured out the issue in a private repo. PHP treats NOWDOC and other strings literally as they are in the source file, so if the source happened to contain garbage characters or CRLF, it keeps it as is. The problem in this case is git's autocrlf setting that is somehow enabled on the github windows runner - when the files are checked out, git was replacing LF with CRLF (even if internally they were stored with LF). A small change to .gitattributes should fix it for everyone. The last remaining issue was about a dev-only requirement for |
|
@christeredvartsen kind reminder - any chance of getting this merged in soon? I'd like to go further with some proposed changes depending on this one. |
This PR changes a few (somewhat unrelated) minor things.
Refer to the comments for an explanation.
Everything should be backward compatible.